Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MSRV check to account for features #260

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Update MSRV check to account for features #260

merged 2 commits into from
Aug 26, 2024

Conversation

danieleades
Copy link
Contributor

@danieleades danieleades commented Aug 25, 2024 •
edited
Loading

updates the MSRV check to account for the serde and tokio-1 features

  • use cargo-no-dev-deps to ensure that dev dependencies don't impact the MSRV
  • checks a matrix of features for the MSRV

note that this would be trivial to modify so that that the matrix had a different MSRV for each feature, depending on the chosen policy of this repo. See #258

@danieleades danieleades marked this pull request as ready for review August 25, 2024 06:14
@danieleades
Copy link
Contributor Author

closes #258

@patrickelectric
Copy link
Member

@danieleades can you solve the conflicts ?

@danieleades
Copy link
Contributor Author

@patrickelectric that's the conflicts resolved

@patrickelectric patrickelectric merged commit d5c5bc3 into mavlink:master Aug 26, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickelectric patrickelectric patrickelectric approved these changes

@joaoantoniocardoso joaoantoniocardoso joaoantoniocardoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danieleades @patrickelectric @joaoantoniocardoso